Fix validation in list comprehension and pattern comprehension #2902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR is to solve #2267. The proposed changes are:
A new function
AR_EXP_ContainsAgg()
was created to check if AR_ExpNode tree contains an aggregating function.If an aggregating function is found, then the function sets the error message and returns true, otherwise, returns false
The function
FilterTree_Valid()
was modified to receive a second parametercypher_astnode_type_t type
. In case of pattern comprehension or list comprehension type, there is a new validation to check that the predicate is not using aggregation functions.To validate list comprehension, the function ``_AR_ExpNodeFromComprehensionFunction()``` was modified:
CYPHER_AST_LIST_COMPREHENSION
typeTo validate pattern comprehension, the function
buildPatternComprehensionOps()
was modified:CYPHER_AST_PATTERN_COMPREHENSION
type