fix(APIv2): bulk deletion should delete link not the entity #2076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk assignment was always deleting the right side from the database when unassigning. This means that when unassigning a system from a tailoring, we didn't delete the
TailoringSystem
record, but theSystem
itself. Same happened forTailoringRule
unassignment. Furthermore, due to the dynamic evaluation of the entities to be unassigned, the unassignment itself interfered with the assignment.So I adjusted the unassignments to deal with the linking entities and reordered the deletion to happen before the assignment. This is something we aren't really able to test in our codebase though 😞
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist