New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(APIv2): RHINENG-2149 implement reports endpoint #2046
feat(APIv2): RHINENG-2149 implement reports endpoint #2046
Conversation
0cc067d
to
e163124
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get inspired by a lot of things from how policies controller + tests are implemented as the DB model is a clone.
2392371
to
5b1f309
Compare
51ccf2d
to
36633a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget about the OpenAPI specs at the end please 🙏
3ee1db8
to
571503e
Compare
a75f7ae
to
39f1b7b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2046 +/- ##
==========================================
+ Coverage 98.77% 98.79% +0.01%
==========================================
Files 224 227 +3
Lines 4753 4825 +72
==========================================
+ Hits 4695 4767 +72
Misses 58 58 ☔ View full report in Codecov by Sentry. |
99a73e6
to
ca1e448
Compare
2b1d03f
to
ca155d7
Compare
073b053
to
0f10fe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests for some systems in inaccessible inventory groups, that's the main selling point of this endpoint.
e6e7316
to
de880f0
Compare
4a055e4
to
c61b791
Compare
c61b791
to
301a340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist