Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading component #56

Merged
merged 6 commits into from Aug 17, 2021
Merged

Loading component #56

merged 6 commits into from Aug 17, 2021

Conversation

jovergaag
Copy link
Contributor

@jovergaag jovergaag commented Aug 17, 2021

Description of the change

Adds a Loading spinner component.

I also updated license-header.js to 2021, which then exploded out to all of the files so it will be best to review this commit by commit. I'm also happy to move the header commit into another PR/tag.

2021-08-16 17 54 09

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Part of #1220 and #7

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@macfarlandian
Copy link
Contributor

See #7 on the license issue, though I wouldn't necessarily say that this closes that.

Could you add the Loading spinner to Storybook also?

@jovergaag
Copy link
Contributor Author

@macfarlandian Added to Storybook!

I agree that this doesn't close #7, but is a step in that direction.

Ready for another review.

Copy link
Contributor

@macfarlandian macfarlandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪐

@jovergaag jovergaag merged commit 6596fb3 into main Aug 17, 2021
@jovergaag jovergaag deleted the jovergaag/54-loading-spinner branch August 17, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants