Add --data-from-json option for initialization of emulator data
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohaibbq
requested review from
a team,
ageiduschek,
colincadams,
ethan-oro,
emilyemilyemilyemilyemilyemily and
recidinick
ethan-oro
approved these changes
Apr 10, 2024
| ] | ||
| } | ||
| ] | ||
| } |
cmd/bigquery-emulator/main.go
Outdated
| @@ -23,6 +23,7 @@ type option struct { | |||
| LogFormat server.LogFormat `description:"specify the log format (console/json)" long:"log-format" default:"console"` | |||
| Database string `description:"specify the database file if required. if not specified, it will be on memory" long:"database"` | |||
| DataFromYAML string `description:"specify the path to the YAML file that contains the initial data" long:"data-from-yaml"` | |||
| DataFromJSON string `description:"specify the path to the JSON file that contains the initial data (faster for large files)" long:"data-from-json"` | |||
There was a problem hiding this comment.
do you have a sense at what size, in general, you would recommend switching from yaml to json? could be helpful to have a general sense (either here or in a doc somewhere) to guide folks
There was a problem hiding this comment.
updated the helpdoc to say "multi-megabyte"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON parser is exponentially faster than the YAML parser for large files