Refactor API data-access pattern to only load what is necessary; use prepared statements #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly improves the performance of the emulator API endpoints.
We no longer load the entire BigQuery project (jobs, datasets, tables, etc) on each request. This was slow for a number of reasons as outlined in goccy#294
We also now utilize unformatted SQLite queries. Previously,
go-zetasqlite
would rewrite the metadata repository queries to use functions likezetasqlite_equals
instead of operators like=
, which meant that SQLite would need to do full table scans when it could be doing more performant query plans.Many endpoints now take tens of microseconds to return instead of 100+ms. Table creation takes roughly ~10ms whereas before we were seeing upwards of 300ms.
We are now able to do a run of
recidiviz.tools.deploy.deploy_empty_test_views
creating & materializing 1,400 viewsagainst the emulator in ~35 seconds.