Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move on NG 17 #23

Merged
merged 3 commits into from Mar 14, 2024
Merged

Move on NG 17 #23

merged 3 commits into from Mar 14, 2024

Conversation

Rebolon
Copy link
Owner

@Rebolon Rebolon commented Mar 12, 2024

manage unsubscribe with takeUntilDestroyed.
Remove OnInit that seems useless now.
Move on Signal

Take care, it's a WIP :

  • after restore team lenght is not recomputed so the blue alert is still displayed
  • after edition of a teammate, the form doesn't disappear and is partially reseted (name is blank)
  • ... need more tests

@Rebolon Rebolon merged commit ba4b9a4 into master Mar 14, 2024
@Rebolon Rebolon mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Rebolon