-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Tabs component with count summary #598
base: develop
Are you sure you want to change the base?
feat: update Tabs component with count summary #598
Conversation
@kedar-hargude is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
8f90bdc
to
a145cfb
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
background: white; | ||
border: none; | ||
padding: 12px 8px 8px; | ||
font-size: 0.8em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check whether em suits better or rem here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it for all dimensions. There is no visible change for such a short value.
src/components/Tabs/Tabs.module.scss
Outdated
font-size: 0.8em; | ||
border: none; | ||
cursor: pointer; | ||
color: #a1a5b7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to create variable name for color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't use a variable name since it's being used only once. But if it's better, then I'll surely use it.
e03a416
to
a8f0d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide test coverage in PR description
a8f0d13
to
013651c
Compare
Issue:
update the Tabs component with the count summary of each Tab
Description:
The Tabs component doesn't show the summary count of the number of tasks for each tab.
Updating the component, upon using feature flag, would show the correct count to the viewer, alongside the tab name and change the design of the tab according to the figma file.
Anthing you would like to inform the reviewer about:
Dev Tested:
Images/video of the change:
Test Coverage
#430