Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The progress bar should be visible only when the task is in progress #1202

Merged
merged 2 commits into from
May 6, 2024

Conversation

tejaskh3
Copy link
Contributor

@tejaskh3 tejaskh3 commented Apr 29, 2024

Date: 30 April, 2024

Developer Name: Tejas


Issue Ticket Number

#1138

Description

The progress bar of the task is only related to the in-progress status. So it should be visible only if the status of the task is in progress.
So, this PR updates the progress bar, only showing it when the task is in "IN_PROGRESS

Documentation Updated?

  • [] Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

image

Test Coverage

image
image
image

Additional Notes

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 11:52am

Copy link

@mehra-sourav mehra-sourav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejaskh3 tejaskh3 changed the title feat:add a check to show progress bar The progress bar of task in card must not visible May 1, 2024
@tejaskh3 tejaskh3 changed the title The progress bar of task in card must not visible The progress bar should be visible only when the task is in progress May 1, 2024
@sahsisunny
Copy link
Member

Why this change is not under the feature flag?

@tejaskh3
Copy link
Contributor Author

tejaskh3 commented May 4, 2024

Why this change is not under the feature flag?

I am not creating a new feature, I am just updating already built feature.
Just putting a if case to render the feature already built.

@sahsisunny
Copy link
Member

Why this change is not under the feature flag?

I am not creating a new feature, I am just updating already built feature. Just putting a if case to render the feature already built.

FF applies for every change please confirm from Ankush or Tejas.

@iamitprakash iamitprakash merged commit dca3ab4 into develop May 6, 2024
3 checks passed
@iamitprakash iamitprakash deleted the progress-bar-new branch May 6, 2024 17:16
@tejaskh3 tejaskh3 mentioned this pull request May 6, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants