Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev to main sync #1187

Merged
merged 1 commit into from
Mar 31, 2024
Merged

dev to main sync #1187

merged 1 commit into from
Mar 31, 2024

Conversation

palakgupta2712
Copy link
Contributor

@palakgupta2712 palakgupta2712 commented Mar 30, 2024

  • bug/extension-req-url: fix extension request url in task details page

Date: 30th March 2024

Developer Name: Palak Gupta


Issue Ticket Number

closes #1168

Description

Expected Behavior
On clicking the extension-request show the whole list of the extension-request for that particular task
The list of extension-requests are not in descending order, due to which older Extension Request shows up first.

Current Behavior
On clicking the extension-request icon, show the whole list of the extension-request for that particular task, with status = "PENDING" and sort the data in descending order of creation of the extension request.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No
Screen.Recording.2024-03-30.at.11.24.02.PM.mov

Screenshots

Test Coverage

Screenshot 1

Additional Notes

…#1185)

* bug/extension-req-url: fix extension request url in task details page

* bug/extension-req-url: fix extension request url in task details page

* bug/extension-req-url: fix extension request url in task details page

---------

Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com>
Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview Mar 30, 2024 5:55pm

@palakgupta2712 palakgupta2712 changed the title bug/extension-req-url: fix extension request url in task details page… dev to main sync Mar 30, 2024
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should have a follow up issue to send multiple params instead of sending a single a param with multiple variables.

@prakashchoudhary07 prakashchoudhary07 merged commit 35ba1d3 into main Mar 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants