Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Make Details Component More Generic #1148

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

ajoykumardas12
Copy link
Contributor

@ajoykumardas12 ajoykumardas12 commented Feb 22, 2024

Date: 23/02/2024

Developer Name: @ajoykumardas12


Issue Ticket Number

closes #1151

Description

  • Made the details component more generic. Details component will only provide the structure and not care about what detail type is rendered.
  • Rendering detail value as children will have the more beneficial than giving option to pass a string value only, for example, now if we need to show a tooltip on detail value we can pass a tooltip component inside Details component.
  • Added option to add additional child in details component, which can be used for extension request link.
  • Option to have text-transform on details value easily.
  • Made separate component for Ends On details for re-usability and also easier to test. This component calls Details component with additional props.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 4:53pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Details Component in task-details
1 participant