Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified task status flow #583

Merged
merged 10 commits into from Mar 22, 2024
Merged

modified task status flow #583

merged 10 commits into from Mar 22, 2024

Conversation

skv93-coder
Copy link
Contributor

@skv93-coder skv93-coder commented Mar 13, 2024

Date: 12-Mar-24

Developer Name: @skv93-coder


Issue Ticket Number

#554

Description

This PR adds message when a user change his task status according to the issue #554. and also removes the functionality marking task done on making progress 100%

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

screen-capture.10.webm
screen-capture.11.webm
Screenshot 1

Test Coverage

Screenshot from 2024-03-22 00-24-52

Screenshot 1

Additional Notes

resetCurrentTask
variable simply holds a function passed to the action
handleUpdateTask
which on call will reset the both task status and progress bar.
earlier it was named error and passed imperatively.

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit bd296b9
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/65fc80daec0303000960daa6
😎 Deploy Preview https://deploy-preview-583--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

app/controllers/tasks.js Outdated Show resolved Hide resolved
app/controllers/tasks.js Outdated Show resolved Hide resolved
app/controllers/tasks.js Outdated Show resolved Hide resolved
@skv93-coder skv93-coder changed the title modified task status flow according to Task card improvements #554 modified task status flow Mar 17, 2024
app/controllers/tasks.js Outdated Show resolved Hide resolved
app/controllers/tasks.js Outdated Show resolved Hide resolved
Atifsid
Atifsid previously approved these changes Mar 19, 2024
palakgupta2712
palakgupta2712 previously approved these changes Mar 20, 2024
app/controllers/tasks.js Outdated Show resolved Hide resolved
app/controllers/tasks.js Outdated Show resolved Hide resolved
app/controllers/tasks.js Outdated Show resolved Hide resolved
tests/integration/components/tasks-test.js Show resolved Hide resolved
@skv93-coder skv93-coder dismissed stale reviews from palakgupta2712 and Atifsid via 325c4bd March 21, 2024 02:52
@skv93-coder skv93-coder merged commit 2e82975 into develop Mar 22, 2024
6 checks passed
@skv93-coder skv93-coder deleted the tasks-status-changes branch March 22, 2024 18:17
@skv93-coder skv93-coder mentioned this pull request Mar 24, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants