Feat/navbar api integration #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-frontend into setup/self-user-query-hook
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying skill-tree-frontend with
|
| Latest commit: |
9885cf2
|
| Status: | 🚫 Build failed. |
Comment on lines
+7
to
+11
| <a key={dropdownItem.id} href={dropdownItem.link}> | ||
| <li className="py-[15px] px-[30px] hover:bg-[#d0e7ff] text-sm transition-background ease-in text-dropdown-blue duration-[380] font-semibold"> | ||
| {dropdownItem.name} | ||
| </li> | ||
| </a> |
There was a problem hiding this comment.
I think it would be more semantically correct, if li tag contained the a tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 26-03-2024
Developer Name: Satyam Bajpai
Issue Ticket Number
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
nav.api.integration.mp4
Test Coverage
Additional Notes