Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config/env vars #68

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Config/env vars #68

merged 4 commits into from
Mar 18, 2024

Conversation

satyam73
Copy link
Member

@satyam73 satyam73 commented Mar 14, 2024

Date: 14-03-2024

Developer Name: Satyam Bajpai


Issue Ticket Number

Description

Warning : This PR should be merged when NEXT_PUBLIC_APP_ENV is set in environment variables where our staging and production are deployed.

Production

NEXT_PUBLIC_APP_ENV - production

Staging

NEXT_PUBLIC_APP_ENV - staging

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skill-tree-frontend-6x4w ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 7:00am

Copy link

cloudflare-pages bot commented Mar 14, 2024

Deploying skill-tree-frontend with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4f312d7
Status:🚫  Build failed.

View logs

process-env.d.ts Outdated
@@ -6,5 +6,6 @@ declare namespace NodeJS {
NEXT_PUBLIC_WELCOME_SITE: string;
NEXT_PUBLIC_WWW_SITE: string;
NEXT_PUBLIC_MY_SITE: string;
NEXT_PUBLIC_APP_ENV: "development" | "production" | "test" | "development";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no staging here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added thanks for pointing out!

@iamitprakash iamitprakash merged commit edc8861 into develop Mar 18, 2024
3 of 4 checks passed
@iamitprakash iamitprakash deleted the config/env-vars branch March 18, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants