chore: update nx to latest, simplify config #7428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
commented
Jan 13, 2024
| @@ -25,15 +26,10 @@ | |||
| }, | |||
| "projectChangelogs": true | |||
| }, | |||
| "groups": { | |||
There was a problem hiding this comment.
A single group is no longer required, we can use the projects shorthand and not need the nested structure (and not need to give it a name)
JamesHenry
commented
Jan 13, 2024
| @@ -56,8 +56,6 @@ const yargs = require('nx/node_modules/yargs'); | |||
|
|
|||
| const { workspaceVersion, projectsVersionData } = await releaseVersion({ | |||
| specifier: options.version, | |||
| // stage package.json updates to be committed later by the changelog command | |||
| stageChanges: true, | |||
There was a problem hiding this comment.
This is essentially always needed for the common case, so it's true by default now
JamesHenry
commented
Jan 17, 2024
| "releaseTagPattern": "{version}", | ||
| "changelog": { | ||
| "git": { |
There was a problem hiding this comment.
Committing and tagging by default after/as part of the changelog generation step just makes a lot sense based on more and more real world usage, so we updated the latest nx to make it so and can streamline the config. As before the logs, in both dry-run and non dry-run, explain when and what git commands are/would be running
benlesh
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains all the latest fixes and DX improvements relevant to
nx release