Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clock package #661

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use clock package #661

wants to merge 2 commits into from

Conversation

hoc081098
Copy link
Collaborator

@hoc081098 hoc081098 commented Feb 2, 2022 •
edited

Issue #660.

  • Replace DateTime.now() with clock.now().
  • Replace Stopwatch with clock.stopwatch().

I don't know if this can cause any breaking changes?

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022 •
edited

Codecov Report

Merging #661 (09bb2cf) into master (c5daf4c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          74       74           
  Lines        2281     2281           
=======================================
  Hits         2133     2133           
  Misses        148      148

@hoc081098 hoc081098 mentioned this pull request Feb 2, 2022
Open
@fzyzcjy
Copy link
Contributor

fzyzcjy commented Jun 8, 2022

Any updates?

@hoc081098 hoc081098 added the under evaluation We are determining the bast way to approach this issue label Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankpepermans frankpepermans Awaiting requested review from frankpepermans

Assignees
No one assigned
Labels
under evaluation We are determining the bast way to approach this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hoc081098 @codecov-commenter @fzyzcjy