Clarify what you can do with the .subscribe Disposable #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, yes it good to precise it here. Especially because many small examples do not show the disposal. @dbrattli I do not understand why the code-quality check fails while they succeed on master. |
There appears to be an issue with isort/poetry which caused issues on multiple repos that depend on this pre-commit; it is fixed in 5.12 and in 5.11.5 (for python 3.7 compatibility) https://github.com/PyCQA/isort/releases/tag/5.11.5 On #689 I attempted to bump isort to that version but my Poetry appears to be a more recent version and made a lot of changes so had to revert. |
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not certain this is right, please correct :)
DisposablenorDisposableBaseare not documented so it wasn't clear what you could do with them.