No "isCompleted" or "isErrored" methods on Observable

[daschl]

Hey folks,

I was currently running into the situation where I just needed a quick check if my observable is already done (and in particular failed), but I wondered why this is not exposed on the Observable - is there any specific reason?

my code was like

if (!observable.isCompleted()) {
 rescheduleIt();
}

[headinthebox]

If you need this, your code is probably too imperative.

But more importantly, it makes no sense for cold observables like Observable.range(1, 10) because that is never completed.

Assuming observable is hot, you can implement it yourself by doing

var isCompleted = false;
val s  = observable.subscribe(x => {}, (e)=>{},()=>{ isCompleted = true; })
...
if (!isCompleted) { rescheduleIt(); }

Note it is dangerous to rely on since there is a race condition

if (!isCompleted) {
  // now it can become completed right here, so you will reschedule anyhow.
 rescheduleIt();
}

[daschl]

@headinthebox thanks, my observable in this case is hot.
The approach here the request which contains the response observable can get redistributed and retried, but the ringbuffer could back it off with a backpressure exception, making it fail.

I'd like to now if it has failed before rescheduling it again.

[akarnokd]

How about using doOnCompleted?

[daschl]

@akarnokd I think I'll go with something simpler, I can fix that in a different place.

It's just something I need to wrap my head around in general I guess, but thanks for the clarification ;). closing then

[abersnaze]

If an Observer/Subscriber receives and onCompleted or onError (or doesn't want to any more onNext for any other reason) then it should unsubscribe from the Subscription. In a way isUnsubscribed on the Subscription/Subscriber can be used as a proxy for isComplete() || isError()

[headinthebox]

Nice catch @abersnaze !