Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Boost For Reddit): Add Fix /s/ links patch #3154

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

OctoNezd
Copy link
Contributor

@OctoNezd OctoNezd commented May 11, 2024

Multi-part PR:

This PR fixes #478

Code is essentially copy-paste from patch for Sync, but with more exception handling and adding the Authorization header to prevent reddit from giving the client page "log in or provide token or else" without proper Location: header.

@OctoNezd
Copy link
Contributor Author

Do I commit the dumped APIs in?

@oSumAtrIX
Copy link
Member

Yes

@OctoNezd OctoNezd changed the title [1/2] Add support for /s/ links on boost for reddit. feat(Boost For Reddit - FixSLinks): [1/2] Add support for /s/ links on boost for reddit. May 11, 2024
@OctoNezd OctoNezd marked this pull request as draft May 16, 2024 14:54
@OctoNezd OctoNezd marked this pull request as ready for review May 16, 2024 15:37
@oSumAtrIX oSumAtrIX changed the title feat(Boost For Reddit - FixSLinks): [1/2] Add support for /s/ links on boost for reddit. feat(Boost For Reddit): Add Fix /s/ links patch May 18, 2024
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Something that should be done before merging would be to introduce a base class for the fix s link patch similar to the client spoof base class. The implementations are very similar and as such qualify for implementations of such a base class.

@OctoNezd OctoNezd requested a review from oSumAtrIX May 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants