refactor: Migrate patches to DSL #3107

Ushie · 2024-05-02T01:58:45Z

No description provided.

src/main/kotlin/app/revanced/patches/youtube/layout/buttons/cast/HideCastButtonPatch.kt

...main/kotlin/app/revanced/patches/youtube/layout/buttons/navigation/NavigationButtonsPatch.kt

...ain/kotlin/app/revanced/patches/youtube/layout/buttons/player/hide/HidePlayerButtonsPatch.kt

...p/revanced/patches/serviceportalbund/detection/root/fingerprints/RootDetectionFingerprint.kt

src/main/kotlin/app/revanced/patches/songpal/badge/BadgeTabPatch.kt

src/main/kotlin/app/revanced/patches/spotify/navbar/PremiumNavbarTabPatch.kt

src/main/kotlin/app/revanced/patches/strava/upselling/DisableSubscriptionSuggestionsPatch.kt

src/main/kotlin/app/revanced/patches/tiktok/feedfilter/FeedFilterPatch.kt

src/main/kotlin/app/revanced/patches/youtube/layout/autocaptions/AutoCaptionsPatch.kt

src/main/kotlin/app/revanced/patches/youtube/layout/buttons/action/HideButtonsPatch.kt

...ain/kotlin/app/revanced/patches/youtube/layout/buttons/player/hide/HidePlayerButtonsPatch.kt

...in/app/revanced/patches/youtube/layout/hide/albumcards/fingerprints/AlbumCardsFingerprint.kt

…sPatch

Ushie · 2024-05-03T18:05:37Z

src/main/kotlin/app/revanced/patches/youtube/interaction/downloads/DownloadsPatch.kt

-                "invoke-static { p0 }, $INTEGRATIONS_CLASS_DESCRIPTOR->activityCreated(Landroid/app/Activity;)V"
-            )
-        }
+//        mainActivityResult.mutableMethod.implementation?.instructions.lastIndex = ""


Need help here

…en dependencies

…refactor/dsl # Conflicts: # src/main/kotlin/app/revanced/patches/finanzonline/detection/bootloader/fingerprints/BootStateFingerprint.kt # src/main/kotlin/app/revanced/patches/finanzonline/detection/bootloader/fingerprints/CreateKeyFingerprint.kt # src/main/kotlin/app/revanced/patches/finanzonline/detection/root/fingerprints/RootDetectionFingerprint.kt # src/main/kotlin/app/revanced/patches/idaustria/detection/root/fingerprints/AttestationSupportedCheckFingerprint.kt # src/main/kotlin/app/revanced/patches/idaustria/detection/root/fingerprints/BootloaderCheckFingerprint.kt # src/main/kotlin/app/revanced/patches/idaustria/detection/root/fingerprints/RootCheckFingerprint.kt # src/main/kotlin/app/revanced/patches/instagram/patches/ads/timeline/fingerprints/IsAdCheckOneFingerprint.kt # src/main/kotlin/app/revanced/patches/instagram/patches/ads/timeline/fingerprints/IsAdCheckTwoFingerprint.kt # src/main/kotlin/app/revanced/patches/instagram/patches/ads/timeline/fingerprints/ShowAdFingerprint.kt # src/main/kotlin/app/revanced/patches/irplus/ad/fingerprints/IrplusAdsFingerprint.kt # src/main/kotlin/app/revanced/patches/lightroom/misc/login/fingerprints/IsLoggedInFingerprint.kt # src/main/kotlin/app/revanced/patches/lightroom/misc/premium/fingerprints/HasPurchasedFingerprint.kt # src/main/kotlin/app/revanced/patches/memegenerator/detection/license/fingerprints/LicenseValidationFingerprint.kt # src/main/kotlin/app/revanced/patches/memegenerator/detection/signature/fingerprints/VerifySignatureFingerprint.kt # src/main/kotlin/app/revanced/patches/memegenerator/misc/pro/fingerprints/IsFreeVersionFingerprint.kt # src/main/kotlin/app/revanced/patches/myfitnesspal/ads/fingerprints/MainActivityNavigateToNativePremiumUpsellFingerprint.kt # src/main/kotlin/app/revanced/patches/nfctoolsse/misc/pro/fingerprints/IsLicenseRegisteredFingerprint.kt # src/main/kotlin/app/revanced/patches/photomath/detection/deviceid/SpoofDeviceIdPatch.kt # src/main/kotlin/app/revanced/patches/photomath/misc/annoyances/HideUpdatePopupPatch.kt # src/main/kotlin/app/revanced/patches/photomath/misc/unlock/bookpoint/fingerprints/IsBookpointEnabledFingerprint.kt # src/main/kotlin/app/revanced/patches/photomath/misc/unlock/plus/UnlockPlusPatch.kt # src/main/kotlin/app/revanced/patches/photomath/misc/unlock/plus/fingerprints/IsPlusUnlockedFingerprint.kt # src/main/kotlin/app/revanced/patches/pixiv/ads/fingerprints/IsNotPremiumFingerprint.kt

…atches into refactor/dsl

.../app/revanced/patches/finanzonline/detection/bootloader/fingerprints/BootStateFingerprint.kt

...vanced/patches/idaustria/detection/root/fingerprints/AttestationSupportedCheckFingerprint.kt

.../kotlin/app/revanced/patches/memegenerator/misc/pro/fingerprints/IsFreeVersionFingerprint.kt

src/main/kotlin/app/revanced/patches/photomath/detection/deviceid/SpoofDeviceIdPatch.kt

src/main/kotlin/app/revanced/patches/serviceportalbund/detection/root/RootDetectionPatch.kt

oSumAtrIX · 2024-06-01T01:50:37Z

src/main/kotlin/app/revanced/patches/spotify/navbar/PremiumNavbarTabResourcePatch.kt

-object PremiumNavbarTabResourcePatch : ResourcePatch() {
-    internal var showBottomNavigationItemsTextId = -1L
-    internal var premiumTabId = -1L
+internal var showBottomNavigationItemsTextId = -1L


The setter should be made private on such properties.

src/main/kotlin/app/revanced/patches/twitch/chat/autoclaim/AutoClaimChannelPointsPatch.kt

oSumAtrIX · 2024-06-01T01:53:33Z

...kotlin/app/revanced/patches/youtube/interaction/seekbar/DisablePreciseSeekingGesturePatch.kt

        )

-        IsSwipingUpFingerprint.result?.let {
+        isSwipingUpResult.let {


I corrected it

oSumAtrIX · 2024-06-01T01:54:25Z

src/main/kotlin/app/revanced/patches/youtube/interaction/seekbar/EnableSeekbarTappingPatch.kt

        )

-        // Find the required methods to tap the seekbar.
-        val seekbarTappingMethods = OnTouchEventHandlerFingerprint.result?.let {
+        val seekbarTappingMethods = onTouchEventHandlerResult.let {


corrected here as well.

oSumAtrIX · 2024-06-01T01:55:25Z

src/main/kotlin/app/revanced/patches/youtube/interaction/seekbar/EnableSlideToSeekPatch.kt

+    val slideToSeekResult by slideToSeekFingerprint
+    val doubleSpeedSeekNoticeResult by doubleSpeedSeekNoticeFingerprint
+
+    val integrationsClassDescriptor = "Lapp/revanced/integrations/youtube/patches/SlideToSeekPatch;"


It was decided to move this to a private (or if necessary internal) constant above the patch, because sometimes fingerprints reference it to keep it consistent.

…m/Ushie/revanced-patches into refactor/dsl

…atches into refactor/dsl

…nnecessarily use classDef.type

refactor: Migrate patches to DSL

9f33a3a

Ushie commented May 2, 2024

View reviewed changes

src/main/kotlin/app/revanced/patches/youtube/layout/buttons/cast/HideCastButtonPatch.kt Outdated Show resolved Hide resolved

Ushie commented May 2, 2024

View reviewed changes

...main/kotlin/app/revanced/patches/youtube/layout/buttons/navigation/NavigationButtonsPatch.kt Outdated Show resolved Hide resolved

Ushie commented May 2, 2024

View reviewed changes

...ain/kotlin/app/revanced/patches/youtube/layout/buttons/player/hide/HidePlayerButtonsPatch.kt Outdated Show resolved Hide resolved

oSumAtrIX requested changes May 2, 2024

View reviewed changes

oSumAtrIX and others added 13 commits May 2, 2024 22:11

formatting

cc2ab50

refactor: Correct ordering of fingerprint block

4574238

fix: Correct package name

e036509

refactor: Place dependsOn before compatibleWith

b01cbf0

refactor: Newline when multiple packages are compatible

00d6229

fix: Reference correct fingerprint result

f53700c

refactor: Move some variables into the patch

8ea3a1d

fix: Add missing integrationsPatch dependency

4a2100f

refactor: Fix formatting and move into patch

f75601c

fix: Use correct dependency

e1eb4ac

refactor: Import PreferenceScreen instead of explicitly using setting…

f4b7a24

…sPatch

refactor: Don't explicitly use With and Let

23dc930

refactor: Improve lambda receiver name

3714ddb

Ushie commented May 3, 2024

View reviewed changes

Ushie added 11 commits May 3, 2024 21:10

refactor: Move onDepends above compatibleWith and add new lines betwe…

f5ff62c

…en dependencies

fix: Import correct dependency (patch hasn't been migrated yet)

44db1f9

refactor: Explicitely name literalSupplier

3e63039

fix: Use correct patchId

89c0a7d

refactor: Move variables inside the patch

bd843e8

fix: Don't use non-existent lambda receiver

baf0d99

refactor: Improve lambda receiver name

7bc1001

fix: Restore original description

3e54a7b

refactor: Use classBy instead of classes.find

20c6949

refactor: Remove unnecessary apply

563e01c

Ushie added 3 commits May 4, 2024 01:11

fix: Add accidentally removed comments

8e13af9

refactor: Move more variables inside the patch

9fdc592

fix: Import correct IntegrationsPatch for TikTok and Twitch

f606e1d

LisoUseInAIKyrios mentioned this pull request May 25, 2024

fix(YouTube): Do not crash if root installation opens a video in the Play store #3084

Open

Merge branch 'refactor/dsl' of https://github.com/revanced/revanced-p…

d4b5ee1

…atches into refactor/dsl

oSumAtrIX requested changes Jun 1, 2024

View reviewed changes

oSumAtrIX and others added 12 commits June 1, 2024 17:47

refactor

a10331c

Merge branches 'refactor/dsl' and 'refactor/dsl' of https://github.co…

9519a5c

…m/Ushie/revanced-patches into refactor/dsl

Merge branch 'refactor/dsl' of https://github.com/revanced/revanced-p…

37ed4d1

…atches into refactor/dsl

refactor: Remove unnecessary .value

a6f3f14

refactor: Use classDef instead of methodDef.definingClass and don't u…

9ef3090

…nnecessarily use classDef.type

refactor: Don't use paranthesis for packages with no version constraints

cdfced3

fix: Supply two arg overload to addResources

11d07b8

refactor: Formatting

2f025ec

refactor: Don't use paranthesis for packages with no version constraints

bd2edf4

refactor: Correctly order fingerprint parameters

02a9d8a

fix: Use classDef.type when comparing string

8e88719

refactor: Remove emptyline in custom

bc01139

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Migrate patches to DSL #3107

refactor: Migrate patches to DSL #3107

Ushie commented May 2, 2024

Ushie May 3, 2024

oSumAtrIX Jun 1, 2024

oSumAtrIX Jun 1, 2024

oSumAtrIX Jun 1, 2024

oSumAtrIX Jun 1, 2024

refactor: Migrate patches to DSL #3107

Are you sure you want to change the base?

refactor: Migrate patches to DSL #3107

Conversation

Ushie commented May 2, 2024

Ushie May 3, 2024

Choose a reason for hiding this comment

oSumAtrIX Jun 1, 2024

Choose a reason for hiding this comment

oSumAtrIX Jun 1, 2024

Choose a reason for hiding this comment

oSumAtrIX Jun 1, 2024

Choose a reason for hiding this comment

oSumAtrIX Jun 1, 2024

Choose a reason for hiding this comment