Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #508

Merged
merged 2 commits into from Oct 19, 2023
Merged

Update README.md #508

merged 2 commits into from Oct 19, 2023

Conversation

woin2ee
Copy link
Contributor

@woin2ee woin2ee commented Sep 2, 2023

  • removed content that no longer applicable parts.
  • updated to latest version.

@woin2ee
Update README.md
fd05804 
- Removed content that no longer applies.
- updated to latest version.
@DivineDominion
Copy link
Contributor

DivineDominion commented Sep 5, 2023 •
edited

Thank you!

I'm fine with this as-is. I mean, who's using Swift 2.2 or 4.x anyway.

Any differing opinions on this, @mjarvis @dani-mp ?

@dani-mp
Copy link
Contributor

dani-mp commented Sep 5, 2023

Sorry, folks, but it's been a while since I was involved in a Swift project so I'm a bit disconnected tbh.

@woin2ee
Copy link
Contributor Author

woin2ee commented Sep 6, 2023

Additionally, I thought this because discussed dropping support for 4.2 and earlier versions at #418

DivineDominion
DivineDominion approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@DivineDominion DivineDominion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! I fixed (?) the CI in the meantime so we're good to go

@DivineDominion DivineDominion merged commit 70dbd75 into ReSwift:master Oct 19, 2023
7 checks passed
@DivineDominion
Copy link
Contributor

We've invited you to join the ReSwift GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DivineDominion DivineDominion DivineDominion approved these changes

@mjarvis mjarvis Awaiting requested review from mjarvis

@dani-mp dani-mp Awaiting requested review from dani-mp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woin2ee @DivineDominion @dani-mp