Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions with new Xcode select action #504

Closed
wants to merge 17 commits into from

Conversation

DivineDominion
Copy link
Contributor

devbotsxyz/xcode-select is archived, so I switched to an action that's still supported: https://github.com/marketplace/actions/xcode-select-version

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Merging #504 (6363944) into master (4cd14d0) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 6363944 differs from pull request most recent head fd30be5. Consider uploading reports for the commit fd30be5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files           6        6           
  Lines         193      193           
=======================================
  Hits          191      191           
  Misses          2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DivineDominion
Copy link
Contributor Author

DivineDominion commented May 1, 2023

We will likely need to adjust the Test Matrix for Xcode 14.

I'm working on that in a parallel branch.

@DivineDominion
Copy link
Contributor Author

@mjarvis Do you have any idea why the iOS test might fail? Asking first to avoid one or more hours of research -- but if you also don't know, no problem :)

@mjarvis
Copy link
Member

mjarvis commented May 2, 2023

@mjarvis Do you have any idea why the iOS test might fail? Asking first to avoid one or more hours of research -- but if you also don't know, no problem :)

Not sure -- I've re-run the job to see if it was just a temporary issue. The xcodebuild command works for me locally.

@DivineDominion
Copy link
Contributor Author

DivineDominion commented May 16, 2023

That's weird.

I've triggered another build with debug logging to see if there's a difference.

This is terrible, because if it continues to fail, the CI step is useless.

@DivineDominion DivineDominion deleted the ctietze/xcode-14-ci branch October 9, 2023 17:03
@DivineDominion
Copy link
Contributor Author

GH Actions broke and merging was impossible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants