Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add automatic skipRepeats for Equatable substate selection (#300)
overrides select to skip repeats when substate is equatable Fixes #298 # Conflicts: # CHANGELOG.md # ReSwiftTests/StoreSubscriberTests.swift # ReSwift/CoreTypes/Store.swift
- Loading branch information
Joseph Cherry
authored and
Malcolm Jarvis
committed
Dec 15, 2017
1 parent
3071038
commit d4cb424
Showing
6 changed files
with
173 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // | ||
| // AutomaticallySkipRepeatsTests.swift | ||
| // ReSwift | ||
| // | ||
| // Created by Daniel Martín Prieto on 03/11/2017. | ||
| // Copyright © 2017 Benjamin Encz. All rights reserved. | ||
| // | ||
| import XCTest | ||
| import ReSwift | ||
|
|
||
| class AutomaticallySkipRepeatsTests: XCTestCase { | ||
|
|
||
| private var store: Store<State>! | ||
| fileprivate var subscriptionUpdates: Int = 0 | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
| // Put setup code here. This method is called before the invocation of each test method in the class. | ||
| store = Store<State>(reducer: reducer, state: nil) | ||
| subscriptionUpdates = 0 | ||
| } | ||
|
|
||
| override func tearDown() { | ||
| // Put teardown code here. This method is called after the invocation of each test method in the class. | ||
| store = nil | ||
| subscriptionUpdates = 0 | ||
| super.tearDown() | ||
| } | ||
|
|
||
| func testInitialSubscription() { | ||
| store.subscribe(self) { $0.select { $0.name } } | ||
| XCTAssertEqual(self.subscriptionUpdates, 1) | ||
| } | ||
|
|
||
| func testDispatchUnrelatedActionWithExplicitSkipRepeats() { | ||
| store.subscribe(self) { $0.select { $0.name }.skipRepeats() } | ||
| XCTAssertEqual(self.subscriptionUpdates, 1) | ||
| store.dispatch(ChangeAge(newAge: 30)) | ||
| XCTAssertEqual(self.subscriptionUpdates, 1) | ||
| } | ||
|
|
||
| func testDispatchUnrelatedActionWithoutExplicitSkipRepeats() { | ||
| store.subscribe(self) { $0.select { $0.name } } | ||
| XCTAssertEqual(self.subscriptionUpdates, 1) | ||
| store.dispatch(ChangeAge(newAge: 30)) | ||
| XCTAssertEqual(self.subscriptionUpdates, 1) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| extension AutomaticallySkipRepeatsTests: StoreSubscriber { | ||
| func newState(state: String) { | ||
| subscriptionUpdates += 1 | ||
| } | ||
| } | ||
|
|
||
| private struct State: StateType { | ||
| let age: Int | ||
| let name: String | ||
| } | ||
|
|
||
| extension State: Equatable { | ||
| static func == (lhs: State, rhs: State) -> Bool { | ||
| return lhs.age == rhs.age && lhs.name == rhs.name | ||
| } | ||
| } | ||
|
|
||
| struct ChangeAge: Action { | ||
| let newAge: Int | ||
| } | ||
|
|
||
| private let initialState = State(age: 29, name: "Daniel") | ||
|
|
||
| private func reducer(action: Action, state: State?) -> State { | ||
| let defaultState = state ?? initialState | ||
| switch action { | ||
| case let changeAge as ChangeAge: | ||
| return State(age: changeAge.newAge, name: defaultState.name) | ||
| default: | ||
| return defaultState | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters