Skip to content

Commit

Permalink
Preventing unexpected actions on solutions' detail page (all solution…
Browse files Browse the repository at this point in the history
… table dialog).
  • Loading branch information
krulis-martin committed Jul 23, 2023
1 parent b7319de commit 31133fb
Showing 1 changed file with 39 additions and 37 deletions.
76 changes: 39 additions & 37 deletions src/components/Assignments/SolutionsTable/SolutionsTableRow.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,43 +133,45 @@ const SolutionsTableRow = ({

{showActionButtons && (
<td className="text-right valign-middle text-nowrap" rowSpan={splitOnTwoLines ? 2 : 1}>
<TheButtonGroup>
{permissionHints && permissionHints.viewDetail && (
<>
<OptionalTooltipWrapper
tooltip={<FormattedMessage id="generic.detail" defaultMessage="Detail" />}
hide={!compact}
tooltipId={`detail-${id}`}>
<Link to={SOLUTION_DETAIL_URI_FACTORY(assignmentId, id)}>
<Button size="xs" variant="secondary" disabled={selected}>
<DetailIcon gapRight={!compact} />
{!compact && <FormattedMessage id="generic.detail" defaultMessage="Detail" />}
</Button>
</Link>
</OptionalTooltipWrapper>

<OptionalTooltipWrapper
tooltip={<FormattedMessage id="app.navigation.solutionFiles" defaultMessage="Submitted Files" />}
hide={!compact}
tooltipId={`codes-${id}`}>
<Link to={SOLUTION_SOURCE_CODES_URI_FACTORY(assignmentId, id)}>
<Button size="xs" variant="primary" disabled={selected}>
<CodeFileIcon fixedWidth gapRight={!compact} />
{!compact && <FormattedMessage id="generic.files" defaultMessage="Files" />}
</Button>
</Link>
</OptionalTooltipWrapper>
</>
)}

{permissionHints && (permissionHints.setFlag || permissionHints.review) && (
<SolutionActionsContainer id={id} captionAsTooltip={compact} showAllButtons dropdown />
)}

{permissionHints && permissionHints.delete && (
<DeleteSolutionButtonContainer id={id} groupId={groupId} size="xs" captionAsTooltip={compact} />
)}
</TheButtonGroup>
{!selected && (
<TheButtonGroup>
{permissionHints && permissionHints.viewDetail && (
<>
<OptionalTooltipWrapper
tooltip={<FormattedMessage id="generic.detail" defaultMessage="Detail" />}
hide={!compact}
tooltipId={`detail-${id}`}>
<Link to={SOLUTION_DETAIL_URI_FACTORY(assignmentId, id)}>
<Button size="xs" variant="secondary" disabled={selected}>
<DetailIcon gapRight={!compact} />
{!compact && <FormattedMessage id="generic.detail" defaultMessage="Detail" />}
</Button>
</Link>
</OptionalTooltipWrapper>

<OptionalTooltipWrapper
tooltip={<FormattedMessage id="app.navigation.solutionFiles" defaultMessage="Submitted Files" />}
hide={!compact}
tooltipId={`codes-${id}`}>
<Link to={SOLUTION_SOURCE_CODES_URI_FACTORY(assignmentId, id)}>
<Button size="xs" variant="primary" disabled={selected}>
<CodeFileIcon fixedWidth gapRight={!compact} />
{!compact && <FormattedMessage id="generic.files" defaultMessage="Files" />}
</Button>
</Link>
</OptionalTooltipWrapper>
</>
)}

{permissionHints && (permissionHints.setFlag || permissionHints.review) && (
<SolutionActionsContainer id={id} captionAsTooltip={compact} showAllButtons dropdown />
)}

{permissionHints && permissionHints.delete && (
<DeleteSolutionButtonContainer id={id} groupId={groupId} size="xs" captionAsTooltip={compact} />
)}
</TheButtonGroup>
)}
</td>
)}
</tr>
Expand Down

0 comments on commit 31133fb

Please sign in to comment.