Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fread(key=character()) #6115

Merged
merged 3 commits into from May 2, 2024
Merged

test fread(key=character()) #6115

merged 3 commits into from May 2, 2024

Conversation

tdhock
Copy link
Member

@tdhock tdhock commented May 1, 2024

this was identified by mutation testing, #6114

fread.R:341

if (length(key) == 1L) {
if (length(key) < 1L) {

changing == to < above resulted in all passing tests, whereas with this new test, there should be a failure with that change.

@tdhock tdhock marked this pull request as ready for review May 1, 2024 21:22
@tdhock tdhock merged commit 83bb3f8 into master May 2, 2024
2 of 4 checks passed
@tdhock tdhock deleted the fread-key-length-0 branch May 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants