Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get code for custom linters working #6099

Merged
merged 1 commit into from May 4, 2024
Merged

get code for custom linters working #6099

merged 1 commit into from May 4, 2024

Conversation

MichaelChirico
Copy link
Member

No description provided.

Copy link
Member Author

MichaelChirico commented Apr 23, 2024

Copy link
Member Author

MichaelChirico commented May 4, 2024

Merge activity

@MichaelChirico MichaelChirico changed the base branch from r32 to master May 4, 2024 16:07
@MichaelChirico MichaelChirico merged commit 05c1d6c into master May 4, 2024
3 checks passed
@MichaelChirico MichaelChirico deleted the lint-r32 branch May 4, 2024 16:10
@MichaelChirico
Copy link
Member Author

@jangorecki FYI. My first time merging a stack all-at-once, we see here that under-the-hood, Graphite is just force-pushing after merging an "up-stack" PR, likely as a way to bulldoze through conflicts after rebase.

@jangorecki
Copy link
Member

Thanks for info. I am not really convinced about using graphite. It creates higher barrier for entry for new contributors. I would definitely go for it when there is team of full time developers, but in situation where we want to attract new volunteer contributors it can be less beneficial.

@MichaelChirico
Copy link
Member Author

It creates higher barrier for entry for new contributors.

I definitely agree with that. currently I'm only using it for ½ or fewer of PRs, wherever a chain feels appropriate. the rest remain in pure git+GitHub. new contributors don't have to know about graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants