New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deparse() to cast calls to string when needed #6027
Open
MichaelChirico
wants to merge
9
commits into
master
Choose a base branch
from
root-call
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColeMiller1
reviewed
Mar 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6027 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 80 80
Lines 14915 14917 +2
=======================================
+ Hits 14547 14549 +2
Misses 368 368 ☔ View full report in Codecov by Sentry. |
MichaelChirico
commented
Mar 28, 2024
MichaelChirico
changed the title
Don't cast jsub[[1]] to character if invalid
Use deparse() to cast calls to string when needed
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6026.
There is some small overhead added here since
jsub %iscall% f
callsis.call()
redundantly a few times.is.call()
is ~50ns to run so I think this can be ignored.