Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lin-ancient job for oldest R dep #5984

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Member

Closes #5978

I couldn't find which PR we discussed this previously, but anyway this should cover us for getting 3.2.0 test back up & running.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (3eefbca) to head (fe9b5ca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5984   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          80       80           
  Lines       14884    14884           
=======================================
  Hits        14513    14513           
  Misses        371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member Author

@jangorecki did I get the tag right? We are getting an error that it's not available IINM

WARNING: Failed to pull image with policy "always": Error response from daemon: manifest for registry.gitlab.com/jangorecki/dockerfiles/r-3.2.0:latest not found: manifest unknown: manifest unknown (manager.go:250:0s)

@jangorecki
Copy link
Member

We don't have image for R 3.2.0 built in the registry: https://gitlab.com/jangorecki/dockerfiles/container_registry

@MichaelChirico
Copy link
Member Author

Filed https://gitlab.com/jangorecki/dockerfiles/-/merge_requests/2, anything else we need to do?

@MichaelChirico
Copy link
Member Author

Ah, found the other related PR: #5906. Let's merge this first to get GLCI back up & running. Marking that as draft for now.

@jangorecki jangorecki added this to the 1.16.0 milestone Mar 18, 2024
@MichaelChirico
Copy link
Member Author

@tdhock do you go by the same username on GitLab? Just realized we should add you as a Member over there too in case you ever need to test changes to GLCI. I also see a @tdhock1.

@tdhock
Copy link
Member

tdhock commented Mar 26, 2024

hmm I guess they are both me, but I haven't used either in years

@MichaelChirico
Copy link
Member Author

@jangorecki ping on the gitlab MR

@jangorecki
Copy link
Member

jangorecki commented Apr 9, 2024

MR was merged 2 weeks ago already.
Images of fixed R versions don't have to be rebuilt each day therefore are not part of CI script, but we need to build them once, to have the image in container registry.
https://gitlab.com/jangorecki/dockerfiles/-/commit/6ab35cde41c611ed969ccc0d79059dd4e5a4d9ef
https://gitlab.com/jangorecki/dockerfiles/-/commit/32b337744c44d4faf35ce821727b7b90f7279ca2
this is how it looked in the past.

@MichaelChirico
Copy link
Member Author

Current CI config looks quite different from your reference, I'm not sure how to proceed:

https://gitlab.com/jangorecki/dockerfiles/-/blob/master/.gitlab-ci.yml?ref_type=heads

@MichaelChirico
Copy link
Member Author

hmm I guess they are both me, but I haven't used either in years

OK, in any case I sent an invite. Can't hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R 3.2.0 job
3 participants