Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable use of by=.I #5235

Merged
merged 6 commits into from Dec 9, 2021
Merged

enable use of by=.I #5235

merged 6 commits into from Dec 9, 2021

Conversation

ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Oct 24, 2021

Closes #1732

edit: Current implementation supports:

by = .I
by = .(.I)
by = list(.I)
by = c(.I)

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #5235 (e136746) into master (75b5d00) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5235   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          77       77           
  Lines       14655    14660    +5     
=======================================
+ Hits        14583    14588    +5     
  Misses         72       72           
Impacted Files Coverage Δ
R/data.table.R 99.89% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b5d00...e136746. Read the comment docs.

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think users will expect by=.(.I) to work as well...

it's fine if its hard to implement that that we skip it for now, but we should clarify that a bit more in the NEWS/docs. as written it will come as a surprise to users.

@ben-schwen
Copy link
Member Author

I think users will expect by=.(.I) to work as well...

Good point. Changed it to support all of the following:

by = .I
by = .(.I)
by = list(.I)
by = c(.I)

@mattdowle mattdowle added this to the 1.14.3 milestone Dec 9, 2021
@mattdowle mattdowle merged commit 8b257b8 into master Dec 9, 2021
@mattdowle mattdowle deleted the by=.I branch December 9, 2021 06:37
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row operations in data.table using by = .I
4 participants