Fix #4783 with a designated option #4947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This continues the discussion in this PR |
|
I'm not sure how to continue - all tests pass for me locally. Could it be a merge conflict I missed? |
inst/tests/tests.Rraw
Outdated
| d[, a:=c(10, 11)] # not leaking to df | ||
| test(2164.2, df$a[1], 1) | ||
| d[!is.na(a), b:=c(20,21)] # leaks to df | ||
| test(2166, df$b[1], 20) |
There was a problem hiding this comment.
the issue is test numbering. here is 2166, next is 2164.3 -- tests should be in increasing order in the file.
There was a problem hiding this comment.
Thanks! I just added another commit (with other improvements) and hopefully this is fixed.
…d of a global option which impacts all DT ops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option that disables in-place assignment - thereby solving #4783 and also indirectly the old #3215.
The option is currently initialized to TRUE (old behaviour) - but at least for us the right initialization is FALSE (fixed behaviour).
Measurements on various size DTs show that the added performance overhead (extra allocations) is definitely manageable.