:= could change calling body and variable in calling scope #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3891 +/- ##
==========================================
- Coverage 99.42% 99.42% -0.01%
==========================================
Files 72 72
Lines 13502 13494 -8
==========================================
- Hits 13425 13417 -8
Misses 77 77
Continue to review full report at Codecov.
|
jangorecki
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3890
Similar area as #3768
The strategy was to reuse the newly centralized
as.data.table.listmore in that section, as the comments there alluded to. Doing that revealed another unrelated difference to 1.12.2 in the auto naming numbers when NULL items are present in the list. Restored the 1.12.2 behavior on that in this PR too and added test.The risk now is more slow downs since as.data.table.list() copies more, currently. Until #617 is done. There's a big TODO in as.data.table.list() for that. The strategy in this release is to get everything central and going through as.data.table.list first. This has eked out the edge cases and plenty of tests have been added via revdep testing too. So now we're in a better place to do #617.