Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy shared columns before setkey #3768

Merged
merged 10 commits into from Aug 27, 2019
Merged

copy shared columns before setkey #3768

merged 10 commits into from Aug 27, 2019

Commits on Aug 15, 2019

  1. Closes #3496 and #3766 -- detect & block setkey from double-reorderin… 

    …g identical columns

vestigial
    Michael Chirico committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    3b3239c View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. also closed #2245; test added

    Michael Chirico committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    9d4e929 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. Merge branch 'master' into setkey_copies

    Michael Chirico committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    acf930c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into setkey_copies

    @mattdowle
    mattdowle committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    0383285 View commit details
    Browse the repository at this point in the history

  3. test number typo

    @mattdowle
    mattdowle committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    df3aed3 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. created copySharedColumns at C level, called from reorder.c at root c… 

    …ause. Faster too by avoiding address() at R level which creates character strings for addresses and avoiding hash table of duplicated(); only noticeable for very many columns.
    @mattdowle
    mattdowle committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    7637f51 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into setkey_copies

    Michael Chirico committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    c39aa3d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'setkey_copies' of https://github.com/Rdatatable/data.table 

     into setkey_copies
    Michael Chirico committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    86b6c95 View commit details
    Browse the repository at this point in the history

  4. remove ancillary issue fix to be filed independently

    Michael Chirico committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    5b59f6e View commit details
    Browse the repository at this point in the history

  5. tweaks to news item and test

    @mattdowle
    mattdowle committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    f7031ba View commit details
    Browse the repository at this point in the history