New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dcast handles fun.aggregate argument better #3384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm will check why it is failing and update |
Not yet done. Will update ASAP. My dev env tests didn't run my tests due to data.table library being loaded and I somehow skipped that. |
I pushed some fixes to pass newly added unit tests. One of them has been turned to |
# Conflicts: # NEWS.md # inst/tests/tests.Rraw
Should be all done now.. hopefully. Feel free to squash while merging. |
Codecov Report
@@ Coverage Diff @@
## master #3384 +/- ##
=========================================
- Coverage 95.11% 95.1% -0.01%
=========================================
Files 65 65
Lines 12118 12126 +8
=========================================
+ Hits 11526 11533 +7
- Misses 592 593 +1
Continue to review full report at Codecov.
|
Closes #2949, closes #1974 and closes #1369. All are identical issues more or less.