Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foverlaps bug fix for overlapping on POSIXct objects < 1970-01-01 #3382

Merged
merged 1 commit into from Feb 11, 2019

Conversation

arunsrinivasan
Copy link
Member

foverlaps returned incorrect results when overlapping on POSIXct dates with datetime values < 1970-01-01. closes #3349

@arunsrinivasan
Copy link
Member Author

@mattdowle added you just to make sure I've created the PR as expected. Committing after a while ..

@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #3382 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
- Coverage   95.09%   95.09%   -0.01%     
==========================================
  Files          65       65              
  Lines       12122    12120       -2     
==========================================
- Hits        11528    11526       -2     
  Misses        594      594
Impacted Files Coverage Δ
R/foverlaps.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd3a46...14e011a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #3382 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
- Coverage   95.09%   95.09%   -0.01%     
==========================================
  Files          65       65              
  Lines       12122    12120       -2     
==========================================
- Hits        11528    11526       -2     
  Misses        594      594
Impacted Files Coverage Δ
R/foverlaps.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd3a46...14e011a. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.2 milestone Feb 11, 2019
@mattdowle mattdowle merged commit 58a9dad into master Feb 11, 2019
@mattdowle mattdowle deleted the fix-3349-foverlaps branch February 11, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The foverlaps() function seems produce an incorrect answer (data.table 1.12.0)
2 participants