Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatable.CJ.names now TRUE by default #3296

Merged
merged 1 commit into from Jan 19, 2019
Merged

datatable.CJ.names now TRUE by default #3296

merged 1 commit into from Jan 19, 2019

Conversation

mattdowle
Copy link
Member

Follow up to #1596
#3295 filed so as to not forget to remove option in 1.13.0

@mattdowle mattdowle added this to the 1.12.2 milestone Jan 19, 2019
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #3296 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3296      +/-   ##
=========================================
- Coverage   94.81%   94.8%   -0.01%     
=========================================
  Files          65      65              
  Lines       12094   12094              
=========================================
- Hits        11467   11466       -1     
- Misses        627     628       +1
Impacted Files Coverage Δ
R/setkey.R 98.26% <100%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65ab18...3c95495. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #3296 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3296      +/-   ##
=========================================
- Coverage   94.81%   94.8%   -0.01%     
=========================================
  Files          65      65              
  Lines       12094   12094              
=========================================
- Hits        11467   11466       -1     
- Misses        627     628       +1
Impacted Files Coverage Δ
R/setkey.R 98.26% <100%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65ab18...3c95495. Read the comment docs.

@mattdowle mattdowle merged commit a0fd463 into master Jan 19, 2019
@mattdowle mattdowle deleted the CJnames branch January 19, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant