New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CJ now auto-names its input #2977
Conversation
I would postpone this to 1.12 |
Codecov Report
@@ Coverage Diff @@
## master #2977 +/- ##
==========================================
+ Coverage 90.82% 90.84% +0.01%
==========================================
Files 61 61
Lines 11736 11738 +2
==========================================
+ Hits 10659 10663 +4
+ Misses 1077 1075 -2
Continue to review full report at Codecov.
|
It could be put in now with an option to turn on new behaviour (default off for now). We're getting used to this option shenanigans now, so it's not really much more effort. Then change default to on in 1.12.0 and the 0.5% of folk that break on 1.12.0 can revert until they update. "Do no harm", right? |
thanks for following up, haven't found time to sit down for this these few weeks +1 |
Closes #1596,
Closes #2192
Related #2081
CJ(a, b)
being namedV1
,V2
(there was in our own testing, after all).if (n < 1L) return( null.data.table() )
moved earlierHope is that this
name_dots
function can be used for fixing this weird autonaming issue as well (but that fix is a bit messier):