32bit rdevel (attempt 2) #2668
Merged
32bit rdevel (attempt 2) #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…order before assumed protection.
Codecov Report
@@ Coverage Diff @@
## master #2668 +/- ##
=========================================
+ Coverage 93.19% 93.2% +<.01%
=========================================
Files 61 61
Lines 12161 12169 +8
=========================================
+ Hits 11334 11342 +8
Misses 827 827
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2658
Continuation of #2665
Have reproduced on Windows 32bit R-devel.
Seems like in bmerge.c somewhere, related to empty join. In agreement with hints from others in #2265
The problem and fix is now known and it's on data.table's side. Thanks to help from Luke Tierney.
Success. Passing 32bit again and re-enabled that job in AppVeyor.