Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some docs fixes for polls #9828

Merged
merged 8 commits into from May 15, 2024
Merged

Some docs fixes for polls #9828

merged 8 commits into from May 15, 2024

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented May 12, 2024

Summary

1st fix: Poll & PollMedia in docs

This is how it actually looks:
how it looks now - POLLMEDIA
It it shown like it is a non-constructable class, when it is, same with discord.Poll.

And this is how it should look (using ForumTag as an example):
how it should look - POLLMEDIA

2nd fix: Missing dot in PollLayoutType & Poll.answers

Like... a missing dot.
missing dot
missing dot 2
missing dot 3

3rd fix: Move PollAnswer to Discord Models

As PollAnswer is not meant to be user constructable it has been moved to Discord Models

4th fix: Make PollMedia have its own reference

Just makes PollMedia has its own reference... as said.

5th fix: Missing space in Poll docs

It is missing a space between "Default" and "to":
missing space

6th fix: poll being undocumented in InteractionResponse.send_message

Well... that.
missing poll

I have not found further errors, so the PR is ready to be merged.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

- PollAnswer is now considered a Discord Model, as it is not meant to be constructed by users.
- PollMedia now has its own section in Data Classes
@DA-344 DA-344 marked this pull request as ready for review May 13, 2024 15:01
@DA-344
Copy link
Contributor Author

DA-344 commented May 13, 2024

The PR is now ready for merging as I haven't found any further errors.

@Rapptz Rapptz merged commit 9d979d3 into Rapptz:master May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants