Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various code around Message.interaction(_metadata) #9819

Merged
merged 1 commit into from May 6, 2024

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented May 6, 2024

Summary

Fix some stuff that was missed in the initial PR:

  1. The original_response_message and interacted_message properties on MessageInteractionMetadata are not marked as Optional.
  2. A weird unformatted deprecation message emitted from Message.interaction.
  3. The library uses the interaction attribute internally for dispatching views so it was always emitting the deprecation message with no way to "fix" it.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz Rapptz merged commit 2248fc1 into Rapptz:master May 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants