Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags positional (consume rest) #9805

Merged
merged 14 commits into from May 5, 2024
Merged

Conversation

Vioshim
Copy link
Contributor

@Vioshim Vioshim commented Apr 25, 2024

Summary

Implemented positional for flags, this should allow to perform flags after the parameter we're intending to use while still remaining compatible with slash commands.

For example (Assuming --message is the positional flag, and defaults to "Hi" ):

?say Hello
?say Hello --ping True
?say --message Hello --ping True
?say --ping True

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems fine as-is, but do you mind adding documentation to the commands.rst file explaining this feature?

@Rapptz Rapptz merged commit 71358b8 into Rapptz:master May 5, 2024
8 checks passed
@Vioshim Vioshim deleted the flags/consume_rest branch May 5, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants