Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Client.close() has finished in __aexit__ #9769

Merged
merged 1 commit into from May 5, 2024
Merged

Ensure Client.close() has finished in __aexit__ #9769

merged 1 commit into from May 5, 2024
+31 −23

Commits on Mar 27, 2024

  1. Ensure Client.close() has finished in __aexit__ 

    This wraps the closing behavior in a task. Subsequent callers of
.close() now await that same close finishing rather than short
circuiting. This prevents a user-called close outside of __aexit__ from
not finishing before no longer having a running event loop.
    @mikeshardmind
    mikeshardmind committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fce0fc3 View commit details
    Browse the repository at this point in the history