First pass at supporting user apps #9760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: red <red@kalab.sk> Co-authored-by: Vioshim <63890837+Vioshim@users.noreply.github.com>
Rapptz
force-pushed
the
feature/user_apps
branch
from
c0f58a1
to
fe165b3
Compare
Rapptz
force-pushed
the
feature/user_apps
branch
from
fe165b3
to
0a0d81d
Compare
Rapptz
force-pushed
the
feature/user_apps
branch
from
c23dc44
to
ff07ad0
Compare
13 tasks
* Refactor values for AppCommandContext and AppInstallationType * Fix initialization of self.context in Interaction class * Try-except approach * Add is_guild_integration and is_user_integration methods to Interaction class * Fix incorrect index in is_user_integration method of Interaction class * Refactor values for AppCommandContext and AppInstallationType * Black formatting * Fix docs for AppCommandContext in interactions.py * Refactor typing imports in installs.py * Add versionadded tags to new methods in Interaction class * Fix incorrect indent in is_user_integration * Add is_integration method to Interaction class * Removed is_integration as it was a bug on discord's end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of previous work by Red in #9406 and their subsequent branch. I've merely adapted and fixed some of it.
There are a few things I'm mostly nebulous about that I need to mull over some more:
authorized_integration_ownertype is pretty useless, I can't imagine a use case for it nor a good way to expose it since its information is duplicated elsewhere in the schema.AppIntegrationTypeas a type feels wrong. It should probably be an enum or renamed toAppInstallationTypesince that's.. what it is. The original naming feels like a misstep on Discord's side.AppContextTypeis anArrayFlagscurrently but due to a losing battle discussing this with them I think this might be better off as anEnuminstead.install_types/user_install/guild_installbut the inner types and properties are calledintegration_types. Again, this feels like a misstep on Discord's side.channel.permissions_forcode that people have littered around.interaction_metadatatype needs to be added toMessageAppInfoneed to be added as well.