New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move most static metadata to pyproject.toml. #9745
Conversation
- The version thing could be done with a setuptools_scm plugin, maybe, but every option that I've seen still requires code, so I'm leaving the current code for creating the version string alone.
Hmm. I'm not sure what's causing the issue here, but I'd guess that moving the data somehow . . . changed the impact of manually setting |
@Rapptz Any pointers on what's causing these tests to fail? Edit: I take it back; the exact command sequence doesn't work locally. I was assuming the 'install requirements' command would installed base dependencies, but it doesn't. Edit2: Managed to figure it out. |
@@ -1,7 +1,84 @@ | |||
[build-system] | |||
requires = ["setuptools", "wheel"] | |||
requires = ["setuptools"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setuptools automatically installs wheel if needed. Further info is in the first note in this section: https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Let's give this a try.
Summary
It moves most of the library's metadata to pyproject.toml from setup.py, excluding the library version due to its particular type of dynamism and the fact that code would seemingly be required for it regardless of possible alternatives like setuptools_scm.
Checklist