Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to pandoc.image.return so it can insert Markdown attributes #302

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adamryczkowski
Copy link

I use it with the pandoc-fignos pandoc plugin to insert image number.

If you don't have the pandoc-fignos, the pandoc should ignore any attributes.

The attribute argument is optional, and it can also be input by the R attribute attached to the path of the image as "pandoc_attributes".

I hope you don't have anything against it.

…utes.\n I use it with the pandoc-fignos pandoc plugin to insert image number.
@adamryczkowski
Copy link
Author

Can someone give me a feedback concerning my pull request? Would you consider it?

@adamryczkowski
Copy link
Author

BTW, what exactly this CI problem mean? What can I do to fix it?

@codecov-io
Copy link

codecov-io commented Aug 28, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b0b475d). Click here to learn what that means.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #302   +/-   ##
=========================================
  Coverage          ?   79.52%           
=========================================
  Files             ?       12           
  Lines             ?     3556           
  Branches          ?        0           
=========================================
  Hits              ?     2828           
  Misses            ?      728           
  Partials          ?        0
Impacted Files Coverage Δ
R/brew.R 84.94% <ø> (ø)
R/pandoc.R 88.88% <ø> (ø)
R/R5.R 95.74% <ø> (ø)
R/S3.R 83.84% <76.19%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b475d...13a1267. Read the comment docs.

@adamryczkowski
Copy link
Author

Can anyone tell me, why you reject my pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants