Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (draft) protobuf io. #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

winterse26
Copy link

Added a draft version for graph io serializing with protobuf. Only a subset of vertex and edge types are covered. However, in our usecase we already got the benefits of less memory consumption and avoidance of precision loss due to the representation as string. The mapping between tags and protobuf enums, although, needs improvment.
If you think the addition could be valueable also for others, we could iterate towards a version that could be merged.

@RainerKuemmerle
Copy link
Owner

In general, I like the idea.
I'm just wondering a bit if we should reason about changes in the g2o API that make things a bit easier. For example, if we would ask each type to provide a toVector/fromVector function both serialization formats could be added on top. And we could drop the individual read/write functions in the types?
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants