Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdgeSE3Expmap was modified #505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

EdgeSE3Expmap was modified #505

wants to merge 1 commit into from

Conversation

dotatw
Copy link

@dotatw dotatw commented Apr 25, 2021

I found that this edge is invalid through some experiments.I wonder if this is dueing to the inconsistent direction of the term shift in the derivation.I try to modified like this, and it works well.

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #505 (9315929) into master (bcb4cb1) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   45.54%   45.56%   +0.01%     
==========================================
  Files         272      272              
  Lines       10483    10479       -4     
==========================================
  Hits         4775     4775              
+ Misses       5708     5704       -4     
Impacted Files Coverage Δ
g2o/types/sba/edge_se3_expmap.cpp 40.90% <0.00%> (+6.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb4cb1...9315929. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant