Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: visibility of heap not changing #165

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: visibility of heap not changing #165

wants to merge 3 commits into from

Conversation

skillor
Copy link

@skillor skillor commented May 2, 2021 •
edited

Hi,
nothing changed when setting the chartVisibility of the heap to false. Here is a quick fix!

@skillor skillor mentioned this pull request May 2, 2021
Open
@dreiekk
Copy link

dreiekk commented Jun 6, 2021

+1

lamweili
lamweili suggested changes May 8, 2022
View reviewed changes
Copy link

@lamweili lamweili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visibility of eventLoop isn't working as well as per #149.
It's definitely missing in the default.css. Perhaps fix it together?

src/public/stylesheets/default.css Show resolved Hide resolved
@skillor @lamweili
Update src/public/stylesheets/default.css
9a7f669 
Co-authored-by: Lam Wei Li <lam_wei_li@hotmail.com>
@lamweili lamweili mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreiekk dreiekk dreiekk approved these changes

@lamweili lamweili lamweili approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skillor @dreiekk @lamweili