Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to RDATE and DATE-OBS header parameters in UVFITS writer
Description
As per #1433, RDATE calculation is odd. I've also updated DATE-OBS to be YYYY-MM-DD, instead of ISOT, as this is what AIPS memo 117 uses.
Motivation and Context
This fixes incorrect RDATE and DATE-OBS header parameters. These parameters are used by MIRIAD when importing UVFITS files, and MIRIAD was getting confused. I'm not sure if CASA uses these when importing uvfits (if it did, I think this would have been caught sooner?)
Types of changes
Checklist:
Bug fix checklist:
Bugfix notes
One unit test now fails,
test_uvfits_extra_params
, due to DUT1 being slightly different (-0.2136028 vs expected -0.2137079). Not sure if test is incorrect, or astropy's DUT1 calculation is unexpected.