Dcp utils miriad baseline fix #1434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIRIAD indexes antennas starting at 1, not 0, so comparator should be >255 instead of >=255
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 37 37
Lines 20869 20869
=======================================
Hits 20853 20853
Misses 16 16 ☔ View full report in Codecov by Sentry. |
bhazelton
reviewed
May 7, 2024
| ant2 = np.array([0, 1, 2, 3, 255, 256]) + 1 # Ant2 array should be 1-based | ||
| bl_gold = np.array([257, 514, 771, 1028, 67840, 67841], dtype="uint64") | ||
| ant1 = np.array([1, 2, 3, 1, 1, 1, 255, 256]) # Ant1 array should be 1-based | ||
| ant2 = np.array([0, 1, 2, 254, 255, 256, 0, 1]) # Ant2 array should be 1-based |
There was a problem hiding this comment.
Why are there zeros in the ant2 array if they are 1-based?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bugfix for MIRIAD baseline calculations.
Description
MIRIAD indexes antennas starting at 1, not 0, so comparator should be >255 instead of >=255. Changed a comparator from
>= 255to>255.Motivation and Context
Minor bugfix for code to calculate baseline ID in MIRIAD convention. The code was correct for 0-indexed antennas (ANT0, ANT1, ...), but MIRIAD uses 1-indexed antennas (ANT1, ANT2 ...).
Types of changes
Checklist:
Bug fix checklist: