New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AnalyticBeam objects and a unified interface for UVBeams and AnalyticBeams #1383
Open
bhazelton
wants to merge
17
commits into
main
Choose a base branch
from
analytic_beam_refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,970
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
========================================
Coverage 99.92% 99.92%
========================================
Files 37 39 +2
Lines 20807 21133 +326
========================================
+ Hits 20791 21117 +326
Misses 16 16
Continue to review full report in Codecov by Sentry.
|
bhazelton
force-pushed
the
analytic_beam_refactor
branch
2 times, most recently
from
February 8, 2024 19:33
9371d2c
to
7a6ac31
Compare
bhazelton
force-pushed
the
analytic_beam_refactor
branch
from
February 15, 2024 22:50
7a6ac31
to
efa8032
Compare
bhazelton
force-pushed
the
analytic_beam_refactor
branch
from
February 25, 2024 02:52
efa8032
to
38e803e
Compare
use typing throughout
Also actually use the kwargs parameter
more test coverage
for more information, see https://pre-commit.ci
bhazelton
force-pushed
the
analytic_beam_refactor
branch
from
March 12, 2024 17:58
38e803e
to
a791f16
Compare
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a refactor of some code that has existed in pyuvsim for some time with some new functionality to make it easier to work with analytic beams.
Major changes:
UVBeam.interp
or the appropriate AnalyticBeam eval method.There are also a couple of minor changes:
Motivation and Context
This will substantially clean up code in pyuvsim, make the analytic beams more accessible for other users and make it easier for simulators by providing a unified interface for UVBeam and Analytic Beam objects.
Types of changes
Checklist:
New feature checklist: